Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin: Remove 'Footnotes' and 'Comments' from the non-dynamic block registration list #54154

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Plugin: Remove 'Footnotes' and 'Comments' from the non-dynamic block registration list #54154

merged 1 commit into from
Sep 4, 2023

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Sep 4, 2023

What?

PR removes duplicate entries for "Comments" and "Footnotes" from the block_folders list as they're later registered as dynamic blocks via block_names.

Testing Instructions

CI should be green.

@Mamaduka Mamaduka added [Type] Task Issues or PRs that have been broken down into an individual action to take Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Sep 4, 2023
@Mamaduka Mamaduka self-assigned this Sep 4, 2023
@Mamaduka Mamaduka requested review from gziolo and ellatrix and removed request for spacedmonkey September 4, 2023 13:49
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/blocks.php

gziolo
gziolo approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. It would be great to stop using a hardcoded list, but it might not be a trivial task if we want to avoid using glob.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Flaky tests detected in 1deec1b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6074322066
📝 Reported issues:

@Mamaduka Mamaduka merged commit 37f52ae into trunk Sep 4, 2023
55 checks passed
@Mamaduka Mamaduka deleted the remove/duplicates-from-non-dynamic-blocks-list branch September 4, 2023 15:00
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 4, 2023
@mikachan mikachan mentioned this pull request Sep 5, 2023
Closed
86 tasks
@mikachan mikachan added [Feature] Block API API that allows to express the block paradigm. [Type] Enhancement A suggestion for improvement. and removed [Type] Task Issues or PRs that have been broken down into an individual action to take labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees

@Mamaduka Mamaduka

Labels
[Feature] Block API API that allows to express the block paradigm. Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 16.7
Development

Successfully merging this pull request may close these issues.
3 participants
@Mamaduka @gziolo @mikachan